Added way to sort user repositories #128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,11 +104,12 @@ public function subscriptions($username) | |||
| * @link http://developer.github.com/v3/repos/ | |||
| * | |||
| * @param string $username the username | |||
| * @param string $sort the repository order | |||
Made use of the parameters array
|
Thank you for contribution but I can't merge it. Two other options are missing: You do not respect code style, and your code is not tested as expected. |
|
Work completed here: #141 thanks for reporting :) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed the option to sort a user repository. Updated it the User.php class